Repository navigation
Add partial yearly holiday references for 117 missing countries - #29
Merged
Merged
Conversation
adulau
marked this pull request as ready for review
October 26, 2026 07:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yearly inference currently includes detailed calendars for 80 countries. Add selected fixed-date national and civic anniversary references for the remaining 117, covering 193 UN members, the Holy See and Palestine, plus Kosovo and Taiwan (197 country candidates).
New candidates explicitly carry
fixed-date references (partial)labels. These sparse references omit movable holidays, observed-day substitutions, regional rules and historical changes; they are not complete public-holiday calendars. Preserve existing detailed and religious calendars, public-worker behavior and weekly timezone inference. Document the exact added countries and coverage limits. Update inventory tests to request the full enlarged candidate pool.Validation: the complete test suite passes locally on Python 3.12 (
python -m pytest -q: 62 passed), including the five new country coverage/integration checks. Python compilation also passes. Dependencies were installed into a project-local virtual environment after granting the installation command network access.